Skip to content

Commit

Permalink
staging: rtl8192e: Fix possible buffer overflow in _rtl92e_wx_set_scan
Browse files Browse the repository at this point in the history
commit 8687bf9 upstream.

Function _rtl92e_wx_set_scan calls memcpy without checking the length.
A user could control that length and trigger a buffer overflow.
Fix by checking the length is within the maximum allowed size.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Lee Gibson <leegib@gmail.com>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210226145157.424065-1-leegib@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
lgtux authored and gregkh committed Mar 17, 2021
1 parent 1a1642a commit 3ff08f7
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
Expand Up @@ -406,9 +406,10 @@ static int _rtl92e_wx_set_scan(struct net_device *dev,
struct iw_scan_req *req = (struct iw_scan_req *)b;

if (req->essid_len) {
ieee->current_network.ssid_len = req->essid_len;
memcpy(ieee->current_network.ssid, req->essid,
req->essid_len);
int len = min_t(int, req->essid_len, IW_ESSID_MAX_SIZE);

ieee->current_network.ssid_len = len;
memcpy(ieee->current_network.ssid, req->essid, len);
}
}

Expand Down

0 comments on commit 3ff08f7

Please sign in to comment.