Skip to content

Commit

Permalink
selftests: net: udpgso_bench_rx/tx: Stop when wrong CLI args are prov…
Browse files Browse the repository at this point in the history
…ided

[ Upstream commit db9b47e ]

Leaving unrecognized arguments buried in the output, can easily hide a
CLI/script typo. Avoid this by exiting when wrong arguments are provided to
the udpgso_bench test programs.

Fixes: 3a687be ("selftests: udp gso benchmark")
Signed-off-by: Andrei Gherzan <andrei.gherzan@canonical.com>
Cc: Willem de Bruijn <willemb@google.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Link: https://lore.kernel.org/r/20230201001612.515730-2-andrei.gherzan@canonical.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
agherzan authored and gregkh committed Feb 9, 2023
1 parent 5bbc22f commit 430bc07
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tools/testing/selftests/net/udpgso_bench_rx.c
Expand Up @@ -336,6 +336,8 @@ static void parse_opts(int argc, char **argv)
cfg_verify = true;
cfg_read_all = true;
break;
default:
exit(1);
}
}

Expand Down
2 changes: 2 additions & 0 deletions tools/testing/selftests/net/udpgso_bench_tx.c
Expand Up @@ -490,6 +490,8 @@ static void parse_opts(int argc, char **argv)
case 'z':
cfg_zerocopy = true;
break;
default:
exit(1);
}
}

Expand Down

0 comments on commit 430bc07

Please sign in to comment.