Skip to content

Commit

Permalink
Revert "dmaengine: qcom_hidma: Check for driver register failure"
Browse files Browse the repository at this point in the history
This reverts commit a474b3f.

Because of recent interactions with developers from @umn.edu, all
commits from them have been recently re-reviewed to ensure if they were
correct or not.

Upon review, this commit was found to be incorrect for the reasons
below, so it must be reverted.  It will be fixed up "correctly" in a
later kernel change.

The original change is NOT correct, as it does not correctly unwind from
the resources that was allocated before the call to
platform_driver_register().

Cc: Aditya Pakki <pakki001@umn.edu>
Acked-By: Vinod Koul <vkoul@kernel.org>
Acked-By: Sinan Kaya <okaya@kernel.org>
Link: https://lore.kernel.org/r/20210503115736.2104747-51-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
gregkh committed May 13, 2021
1 parent c6052f0 commit 43ed0fc
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/dma/qcom/hidma_mgmt.c
Original file line number Diff line number Diff line change
Expand Up @@ -418,8 +418,9 @@ static int __init hidma_mgmt_init(void)
hidma_mgmt_of_populate_channels(child);
}
#endif
return platform_driver_register(&hidma_mgmt_driver);
platform_driver_register(&hidma_mgmt_driver);

return 0;
}
module_init(hidma_mgmt_init);
MODULE_LICENSE("GPL v2");

0 comments on commit 43ed0fc

Please sign in to comment.