Skip to content

Commit

Permalink
drivers: net: mhi: fix error path in mhi_net_newlink
Browse files Browse the repository at this point in the history
Fix double free_netdev when mhi_prepare_for_transfer fails.

Fixes: 3ffec6a ("net: Add mhi-net driver")
Signed-off-by: Daniele Palmas <dnlplm@gmail.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Reviewed-by: Loic Poulain <loic.poulain@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
dnlplm authored and davem330 committed Sep 24, 2021
1 parent 5ab8a44 commit 4526fe7
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions drivers/net/mhi_net.c
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ static int mhi_net_newlink(struct mhi_device *mhi_dev, struct net_device *ndev)
/* Start MHI channels */
err = mhi_prepare_for_transfer(mhi_dev);
if (err)
goto out_err;
return err;

/* Number of transfer descriptors determines size of the queue */
mhi_netdev->rx_queue_sz = mhi_get_free_desc_count(mhi_dev, DMA_FROM_DEVICE);
Expand All @@ -331,10 +331,6 @@ static int mhi_net_newlink(struct mhi_device *mhi_dev, struct net_device *ndev)
return err;

return 0;

out_err:
free_netdev(ndev);
return err;
}

static void mhi_net_dellink(struct mhi_device *mhi_dev, struct net_device *ndev)
Expand Down

0 comments on commit 4526fe7

Please sign in to comment.