Skip to content

Commit

Permalink
Revert "media: dvb: Add check on sp8870_readreg"
Browse files Browse the repository at this point in the history
This reverts commit 467a37f.

Because of recent interactions with developers from @umn.edu, all
commits from them have been recently re-reviewed to ensure if they were
correct or not.

Upon review, this commit was found to be incorrect for the reasons
below, so it must be reverted.  It will be fixed up "correctly" in a
later kernel change.

This commit is not properly checking for an error at all, so if a
read succeeds from this device, it will error out.

Cc: Aditya Pakki <pakki001@umn.edu>
Cc: Sean Young <sean@mess.org>
Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Link: https://lore.kernel.org/r/20210503115736.2104747-59-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
gregkh committed May 13, 2021
1 parent 2da441a commit 47e4ff0
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/media/dvb-frontends/sp8870.c
Original file line number Diff line number Diff line change
Expand Up @@ -280,9 +280,7 @@ static int sp8870_set_frontend_parameters(struct dvb_frontend *fe)
sp8870_writereg(state, 0xc05, reg0xc05);

// read status reg in order to clear pending irqs
err = sp8870_readreg(state, 0x200);
if (err)
return err;
sp8870_readreg(state, 0x200);

// system controller start
sp8870_microcontroller_start(state);
Expand Down

0 comments on commit 47e4ff0

Please sign in to comment.