Skip to content

Commit

Permalink
btrfs: use kvzalloc() to allocate clone_roots in btrfs_ioctl_send()
Browse files Browse the repository at this point in the history
commit 8eb2fd0 upstream.

btrfs_ioctl_send() used open-coded kvzalloc implementation earlier.
The code was accidentally replaced with kzalloc() call [1]. Restore
the original code by using kvzalloc() to allocate sctx->clone_roots.

[1] https://patchwork.kernel.org/patch/9757891/#20529627

Fixes: 818e010 ("btrfs: replace opencoded kvzalloc with the helper")
CC: stable@vger.kernel.org # 4.14+
Signed-off-by: Denis Efremov <efremov@linux.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
evdenis authored and gregkh committed Nov 5, 2020
1 parent 6ec4b82 commit 4b82b8a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/btrfs/send.c
Expand Up @@ -7352,7 +7352,7 @@ long btrfs_ioctl_send(struct file *mnt_file, struct btrfs_ioctl_send_args *arg)

alloc_size = sizeof(struct clone_root) * (arg->clone_sources_count + 1);

sctx->clone_roots = kzalloc(alloc_size, GFP_KERNEL);
sctx->clone_roots = kvzalloc(alloc_size, GFP_KERNEL);
if (!sctx->clone_roots) {
ret = -ENOMEM;
goto out;
Expand Down

0 comments on commit 4b82b8a

Please sign in to comment.