Skip to content

Commit

Permalink
ASoC: ti: omap-mcbsp: Fix runtime PM underflow warnings
Browse files Browse the repository at this point in the history
[ Upstream commit fbb74e5 ]

We need to check for an active device as otherwise we get warnings
for some mcbsp instances for "Runtime PM usage count underflow!".

Reported-by: Andreas Kemnade <andreas@kemnade.info>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Link: https://lore.kernel.org/r/20231030052340.13415-1-tony@atomide.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
tmlind authored and gregkh committed Nov 28, 2023
1 parent fe4eb21 commit 4e35ae9
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions sound/soc/ti/omap-mcbsp.c
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,16 @@ static int omap2_mcbsp_set_clks_src(struct omap_mcbsp *mcbsp, u8 fck_src_id)
return -EINVAL;
}

pm_runtime_put_sync(mcbsp->dev);
if (mcbsp->active)
pm_runtime_put_sync(mcbsp->dev);

r = clk_set_parent(mcbsp->fclk, fck_src);
if (r)
dev_err(mcbsp->dev, "CLKS: could not clk_set_parent() to %s\n",
src);

pm_runtime_get_sync(mcbsp->dev);
if (mcbsp->active)
pm_runtime_get_sync(mcbsp->dev);

clk_put(fck_src);

Expand Down

0 comments on commit 4e35ae9

Please sign in to comment.