Skip to content

Commit

Permalink
ALSA: caiaq: input: Add error handling for unsupported input methods …
Browse files Browse the repository at this point in the history
…in `snd_usb_caiaq_input_init`

[ Upstream commit 0d727e1 ]

Smatch complains that:
snd_usb_caiaq_input_init() warn: missing error code 'ret'

This patch adds a new case to handle the situation where the
device does not support any input methods in the
`snd_usb_caiaq_input_init` function. It returns an `-EINVAL` error code
to indicate that no input methods are supported on the device.

Fixes: 523f1dc ("[ALSA] Add Native Instrument usb audio device support")
Signed-off-by: Ruliang Lin <u202112092@hust.edu.cn>
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
Acked-by: Daniel Mack <daniel@zonque.org>
Link: https://lore.kernel.org/r/20230504065054.3309-1-u202112092@hust.edu.cn
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Ruliang Lin authored and gregkh committed May 17, 2023
1 parent 7887397 commit 4e875cf
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions sound/usb/caiaq/input.c
Original file line number Diff line number Diff line change
Expand Up @@ -804,6 +804,7 @@ int snd_usb_caiaq_input_init(struct snd_usb_caiaqdev *cdev)

default:
/* no input methods supported on this device */
ret = -EINVAL;
goto exit_free_idev;
}

Expand Down

0 comments on commit 4e875cf

Please sign in to comment.