Skip to content

Commit

Permalink
ovl: fix NULL pointer dereference in copy up warning
Browse files Browse the repository at this point in the history
This patch is fixing a NULL pointer dereference to get a recently
introduced warning message working.

Fixes: 5b0a414 ("ovl: fix filattr copy-up failure")
Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
Cc: <stable@vger.kernel.org> # v5.15
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
  • Loading branch information
ch-f authored and Miklos Szeredi committed Jan 14, 2022
1 parent df0cc57 commit 4ee7e4a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions fs/overlayfs/copy_up.c
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ static int ovl_copy_fileattr(struct inode *inode, struct path *old,
if (err == -ENOTTY || err == -EINVAL)
return 0;
pr_warn("failed to retrieve lower fileattr (%pd2, err=%i)\n",
old, err);
old->dentry, err);
return err;
}

Expand All @@ -168,7 +168,7 @@ static int ovl_copy_fileattr(struct inode *inode, struct path *old,
err = ovl_real_fileattr_get(new, &newfa);
if (err) {
pr_warn("failed to retrieve upper fileattr (%pd2, err=%i)\n",
new, err);
new->dentry, err);
return err;
}

Expand Down

0 comments on commit 4ee7e4a

Please sign in to comment.