Skip to content

Commit

Permalink
drm/msm: Update dev core dump to not print backwards
Browse files Browse the repository at this point in the history
[ Upstream commit 9037051 ]

Device core dump add block method adds hardware blocks to dumping queue
with stack behavior which causes the hardware blocks to be printed in
reverse order. Change the addition to dumping queue data structure
from "list_add" to "list_add_tail" for FIFO queue behavior.

Fixes: 9865948 ("drm/msm: add support to take dpu snapshot")
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Signed-off-by: Ryan McCann <quic_rmccann@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/546200/
Link: https://lore.kernel.org/r/20230622-devcoredump_patch-v5-1-67e8b66c4723@quicinc.com
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Ryan McCann authored and gregkh committed Sep 13, 2023
1 parent f9b9c6b commit 508383d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c
Expand Up @@ -192,5 +192,5 @@ void msm_disp_snapshot_add_block(struct msm_disp_state *disp_state, u32 len,
new_blk->base_addr = base_addr;

msm_disp_state_dump_regs(&new_blk->state, new_blk->size, base_addr);
list_add(&new_blk->node, &disp_state->blocks);
list_add_tail(&new_blk->node, &disp_state->blocks);
}

0 comments on commit 508383d

Please sign in to comment.