Skip to content

Commit

Permalink
iio: imu: inv_icm42600: Fix broken icm42600 (chip id 0 value)
Browse files Browse the repository at this point in the history
commit 106b391 upstream.

The 0 value used for INV_CHIP_ICM42600 was not working since the
match in i2c/spi was checking against NULL value.

To keep this check, add a first INV_CHIP_INVALID 0 value as safe
guard.

Fixes: 31c24c1 ("iio: imu: inv_icm42600: add core of new inv_icm42600 driver")
Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
Link: https://lore.kernel.org/r/20220609102301.4794-1-jmaneyrol@invensense.com
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
jmaneyrol-invn authored and gregkh committed Jun 29, 2022
1 parent 011f3bf commit 50a968c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions drivers/iio/imu/inv_icm42600/inv_icm42600.h
Expand Up @@ -17,6 +17,7 @@
#include "inv_icm42600_buffer.h"

enum inv_icm42600_chip {
INV_CHIP_INVALID,
INV_CHIP_ICM42600,
INV_CHIP_ICM42602,
INV_CHIP_ICM42605,
Expand Down
2 changes: 1 addition & 1 deletion drivers/iio/imu/inv_icm42600/inv_icm42600_core.c
Expand Up @@ -565,7 +565,7 @@ int inv_icm42600_core_probe(struct regmap *regmap, int chip, int irq,
bool open_drain;
int ret;

if (chip < 0 || chip >= INV_CHIP_NB) {
if (chip <= INV_CHIP_INVALID || chip >= INV_CHIP_NB) {
dev_err(dev, "invalid chip = %d\n", chip);
return -ENODEV;
}
Expand Down

0 comments on commit 50a968c

Please sign in to comment.