Skip to content

Commit

Permalink
iommu/dma: Fix compile warning in 32-bit builds
Browse files Browse the repository at this point in the history
commit 7154cbd upstream.

Compiling the recent dma-iommu changes under 32-bit x86 triggers this
compile warning:

drivers/iommu/dma-iommu.c:249:5: warning: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 3 has type ‘phys_addr_t’ {aka ‘unsigned int’} [-Wformat=]

The reason is that %llx is used to print a variable of type
phys_addr_t. Fix it by using the correct %pa format specifier for
phys_addr_t.

Cc: Srinath Mannam <srinath.mannam@broadcom.com>
Cc: Robin Murphy <robin.murphy@arm.com>
Cc: Oza Pawandeep <poza@codeaurora.org>
Fixes: 571f316 ("iommu/dma: Fix IOVA reserve dma ranges")
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Link: https://lore.kernel.org/r/20210607124905.27525-1-joro@8bytes.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
joergroedel authored and gregkh committed Jul 14, 2021
1 parent 572b2a6 commit 51189a3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/iommu/dma-iommu.c
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,8 @@ static int iova_reserve_pci_windows(struct pci_dev *dev,
} else if (end < start) {
/* dma_ranges list should be sorted */
dev_err(&dev->dev,
"Failed to reserve IOVA [%#010llx-%#010llx]\n",
start, end);
"Failed to reserve IOVA [%pa-%pa]\n",
&start, &end);
return -EINVAL;
}

Expand Down

0 comments on commit 51189a3

Please sign in to comment.