Skip to content

Commit

Permalink
crypto: qat - do not ignore errors from enable_vf2pf_comms()
Browse files Browse the repository at this point in the history
The function adf_dev_init() ignores the error code reported by
enable_vf2pf_comms(). If the latter fails, e.g. the VF is not compatible
with the pf, then the load of the VF driver progresses.
This patch changes adf_dev_init() so that the error code from
enable_vf2pf_comms() is returned to the caller.

Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Reviewed-by: Marco Chiappero <marco.chiappero@intel.com>
Reviewed-by: Fiona Trahe <fiona.trahe@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
gcabiddu authored and herbertx committed Aug 21, 2021
1 parent a48afd6 commit 5147f09
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions drivers/crypto/qat/qat_common/adf_init.c
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ int adf_dev_init(struct adf_accel_dev *accel_dev)
struct service_hndl *service;
struct list_head *list_itr;
struct adf_hw_device_data *hw_data = accel_dev->hw_device;
int ret;

if (!hw_data) {
dev_err(&GET_DEV(accel_dev),
Expand Down Expand Up @@ -127,9 +128,9 @@ int adf_dev_init(struct adf_accel_dev *accel_dev)
}

hw_data->enable_error_correction(accel_dev);
hw_data->enable_vf2pf_comms(accel_dev);
ret = hw_data->enable_vf2pf_comms(accel_dev);

return 0;
return ret;
}
EXPORT_SYMBOL_GPL(adf_dev_init);

Expand Down

0 comments on commit 5147f09

Please sign in to comment.