Skip to content

Commit

Permalink
pwm: imx1: Don't disable clocks at device remove time
Browse files Browse the repository at this point in the history
[ Upstream commit 1bc6ea3 ]

The .remove() callback disables clocks that were not enabled in
.probe(). So just probing and then unbinding the driver results in a clk
enable imbalance.

So just drop the call to disable the clocks. (Which BTW was also in the
wrong order because the call makes the PWM unfunctional and so should
have come only after pwmchip_remove()).

Fixes: 9f4c8f9 ("pwm: imx: Add ipg clock operation")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
ukleinek authored and gregkh committed Jul 20, 2021
1 parent 12d84de commit 527bb29
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/pwm/pwm-imx1.c
Expand Up @@ -180,8 +180,6 @@ static int pwm_imx1_remove(struct platform_device *pdev)
{
struct pwm_imx1_chip *imx = platform_get_drvdata(pdev);

pwm_imx1_clk_disable_unprepare(&imx->chip);

return pwmchip_remove(&imx->chip);
}

Expand Down

0 comments on commit 527bb29

Please sign in to comment.