Skip to content

Commit

Permalink
usb: typec: Return size of buffer if pd_set operation succeeds
Browse files Browse the repository at this point in the history
The attribute writing should return the number of bytes used from the
buffer on success.

Fixes: a7cff92 ("usb: typec: USB Power Delivery helpers for ports and partners")
Cc: stable@vger.kernel.org
Signed-off-by: Kyle Tso <kyletso@google.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20240319074309.3306579-1-kyletso@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
kyletsoadl authored and gregkh committed Mar 26, 2024
1 parent 2a587a0 commit 53f5094
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion drivers/usb/typec/class.c
Original file line number Diff line number Diff line change
Expand Up @@ -1310,6 +1310,7 @@ static ssize_t select_usb_power_delivery_store(struct device *dev,
{
struct typec_port *port = to_typec_port(dev);
struct usb_power_delivery *pd;
int ret;

if (!port->ops || !port->ops->pd_set)
return -EOPNOTSUPP;
Expand All @@ -1318,7 +1319,11 @@ static ssize_t select_usb_power_delivery_store(struct device *dev,
if (!pd)
return -EINVAL;

return port->ops->pd_set(port, pd);
ret = port->ops->pd_set(port, pd);
if (ret)
return ret;

return size;
}

static ssize_t select_usb_power_delivery_show(struct device *dev,
Expand Down

0 comments on commit 53f5094

Please sign in to comment.