Skip to content

Commit

Permalink
firmware: arm_ffa: Remove incorrect assignment of driver_data
Browse files Browse the repository at this point in the history
[ Upstream commit 00512d2 ]

The ffa core driver currently assigns its own driver information
to individual ffa device driver_data which is wrong. Firstly, it leaks
this core driver information to individual ffa_device and hence to
ffa_driver. Secondly the ffa_device driver_data is for use by individual
ffa_driver and not for this core driver managing all those devices.

Link: https://lore.kernel.org/r/20220429113946.2087145-2-sudeep.holla@arm.com
Fixes: d0c0bce ("firmware: arm_ffa: Setup in-kernel users of FFA partitions")
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
sudeep-holla authored and gregkh committed Jun 9, 2022
1 parent 5d2387e commit 564580d
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/firmware/arm_ffa/driver.c
Expand Up @@ -688,8 +688,6 @@ static void ffa_setup_partitions(void)
__func__, tpbuf->id);
continue;
}

ffa_dev_set_drvdata(ffa_dev, drv_info);
}
kfree(pbuf);
}
Expand Down

0 comments on commit 564580d

Please sign in to comment.