Skip to content

Commit

Permalink
ALSA: hda/tas2781: reset the amp before component_add
Browse files Browse the repository at this point in the history
commit 315deab upstream.

Calling component_add starts loading the firmware, the callback function
writes the program to the amplifiers. If the module resets the
amplifiers after component_add, it happens that one of the amplifiers
does not work because the reset and program writing are interleaving.

Call tas2781_reset before component_add to ensure reliable
initialization.

Fixes: 5be27f1 ("ALSA: hda/tas2781: Add tas2781 HDA driver")
CC: stable@vger.kernel.org
Signed-off-by: Gergo Koteles <soyer@irl.hu>
Link: https://lore.kernel.org/r/4d23bf58558e23ee8097de01f70f1eb8d9de2d15.1702511246.git.soyer@irl.hu
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
soyersoyer authored and gregkh committed Dec 20, 2023
1 parent d94fad0 commit 56e2212
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions sound/pci/hda/tas2781_hda_i2c.c
Expand Up @@ -674,14 +674,14 @@ static int tas2781_hda_i2c_probe(struct i2c_client *clt)

pm_runtime_put_autosuspend(tas_priv->dev);

tas2781_reset(tas_priv);

ret = component_add(tas_priv->dev, &tas2781_hda_comp_ops);
if (ret) {
dev_err(tas_priv->dev, "Register component failed: %d\n", ret);
pm_runtime_disable(tas_priv->dev);
goto err;
}

tas2781_reset(tas_priv);
err:
if (ret)
tas2781_hda_remove(&clt->dev);
Expand Down

0 comments on commit 56e2212

Please sign in to comment.