Skip to content

Commit

Permalink
gpio: mxc: Always set GPIOs used as interrupt source to INPUT mode
Browse files Browse the repository at this point in the history
[ Upstream commit 8e88a0f ]

Always configure GPIO pins which are used as interrupt source as INPUTs.
In case the default pin configuration is OUTPUT, or the prior stage does
configure the pins as OUTPUT, then Linux will not reconfigure the pin as
INPUT and no interrupts are received.

Always configure the interrupt source GPIO pin as input to fix the above case.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Fixes: 07bd1a6 ("MXC arch: Add gpio support for the whole platform")
Signed-off-by: Marek Vasut <marex@denx.de>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Marek Vasut authored and gregkh committed Feb 1, 2023
1 parent 4141fdf commit 56e3e8d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpio/gpio-mxc.c
Expand Up @@ -210,7 +210,7 @@ static int gpio_set_irq_type(struct irq_data *d, u32 type)

raw_spin_unlock_irqrestore(&port->gc.bgpio_lock, flags);

return 0;
return port->gc.direction_input(&port->gc, gpio_idx);
}

static void mxc_flip_edge(struct mxc_gpio_port *port, u32 gpio)
Expand Down

0 comments on commit 56e3e8d

Please sign in to comment.