Skip to content

Commit

Permalink
serial: 8250: 8250_omap: Fix RX_LVL register offset
Browse files Browse the repository at this point in the history
commit 79e9e30 upstream.

Commit b67e830 ("serial: 8250: 8250_omap: Fix possible interrupt
storm on K3 SoCs") introduced fixup including a register read to
RX_LVL, however, we should be using word offset than byte offset
since our registers are on 4 byte boundary (port.regshift = 2) for
8250_omap.

Fixes: b67e830 ("serial: 8250: 8250_omap: Fix possible interrupt storm on K3 SoCs")
Cc: stable <stable@vger.kernel.org>
Cc: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
Link: https://lore.kernel.org/r/20210903050550.29050-1-nm@ti.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
nmenon authored and gregkh committed Sep 30, 2021
1 parent 807ac76 commit 590e6c4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/tty/serial/8250/8250_omap.c
Expand Up @@ -106,7 +106,7 @@
#define UART_OMAP_EFR2_TIMEOUT_BEHAVE BIT(6)

/* RX FIFO occupancy indicator */
#define UART_OMAP_RX_LVL 0x64
#define UART_OMAP_RX_LVL 0x19

struct omap8250_priv {
int line;
Expand Down

0 comments on commit 590e6c4

Please sign in to comment.