Skip to content

Commit

Permalink
io_uring: revert "io_uring fix multishot accept ordering"
Browse files Browse the repository at this point in the history
From: Dylan Yudaken <dylany@meta.com>

[ upstream commit 515e269 ]

This is no longer needed after commit aa1df3a ("io_uring: fix CQE
reordering"), since all reordering is now taken care of.

This reverts commit cbd2574 ("io_uring: fix multishot accept
ordering").

Signed-off-by: Dylan Yudaken <dylany@meta.com>
Link: https://lore.kernel.org/r/20221107125236.260132-2-dylany@meta.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
isilence authored and gregkh committed Sep 19, 2023
1 parent fd45920 commit 5afbf7f
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions io_uring/net.c
Expand Up @@ -1337,12 +1337,12 @@ int io_accept(struct io_kiocb *req, unsigned int issue_flags)
return IOU_OK;
}

if (ret >= 0 &&
io_post_aux_cqe(ctx, req->cqe.user_data, ret, IORING_CQE_F_MORE, false))
if (ret < 0)
return ret;
if (io_post_aux_cqe(ctx, req->cqe.user_data, ret, IORING_CQE_F_MORE, true))
goto retry;

io_req_set_res(req, ret, 0);
return (issue_flags & IO_URING_F_MULTISHOT) ? IOU_STOP_MULTISHOT : IOU_OK;
return -ECANCELED;
}

int io_socket_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
Expand Down

0 comments on commit 5afbf7f

Please sign in to comment.