Skip to content

Commit

Permalink
usb: renesas: Fix refcount leak bug
Browse files Browse the repository at this point in the history
[ Upstream commit 9d6d530 ]

In usbhs_rza1_hardware_init(), of_find_node_by_name() will return
a node pointer with refcount incremented. We should use of_node_put()
when it is not used anymore.

Signed-off-by: Liang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220618023205.4056548-1-windhl@126.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
windhl authored and gregkh committed Aug 25, 2022
1 parent 4031328 commit 5c4b699
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/usb/renesas_usbhs/rza.c
Expand Up @@ -23,6 +23,10 @@ static int usbhs_rza1_hardware_init(struct platform_device *pdev)
extal_clk = of_find_node_by_name(NULL, "extal");
of_property_read_u32(usb_x1_clk, "clock-frequency", &freq_usb);
of_property_read_u32(extal_clk, "clock-frequency", &freq_extal);

of_node_put(usb_x1_clk);
of_node_put(extal_clk);

if (freq_usb == 0) {
if (freq_extal == 12000000) {
/* Select 12MHz XTAL */
Expand Down

0 comments on commit 5c4b699

Please sign in to comment.