Skip to content

Commit

Permalink
usb: typec: Use sysfs_emit_at when concatenating the string
Browse files Browse the repository at this point in the history
commit 609fded upstream.

The buffer address used in sysfs_emit should be aligned to PAGE_SIZE.
Use sysfs_emit_at instead to offset the buffer.

Fixes: a7cff92 ("usb: typec: USB Power Delivery helpers for ports and partners")
Cc: stable@vger.kernel.org
Signed-off-by: Kyle Tso <kyletso@google.com>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20230623151036.3955013-4-kyletso@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
kyletsoadl authored and gregkh committed Aug 3, 2023
1 parent 9e4c1e6 commit 60816ac
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/usb/typec/class.c
Original file line number Diff line number Diff line change
Expand Up @@ -1269,9 +1269,9 @@ static ssize_t select_usb_power_delivery_show(struct device *dev,

for (i = 0; pds[i]; i++) {
if (pds[i] == port->pd)
ret += sysfs_emit(buf + ret, "[%s] ", dev_name(&pds[i]->dev));
ret += sysfs_emit_at(buf, ret, "[%s] ", dev_name(&pds[i]->dev));
else
ret += sysfs_emit(buf + ret, "%s ", dev_name(&pds[i]->dev));
ret += sysfs_emit_at(buf, ret, "%s ", dev_name(&pds[i]->dev));
}

buf[ret - 1] = '\n';
Expand Down

0 comments on commit 60816ac

Please sign in to comment.