Skip to content

Commit

Permalink
tipc: fix shift wrapping bug in map_get()
Browse files Browse the repository at this point in the history
[ Upstream commit e2b224a ]

There is a shift wrapping bug in this code so anything thing above
31 will return false.

Fixes: 35c55c9 ("tipc: add neighbor monitoring framework")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Dan Carpenter authored and gregkh committed Sep 15, 2022
1 parent 8f796f3 commit 63e19e5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/tipc/monitor.c
Expand Up @@ -160,7 +160,7 @@ static void map_set(u64 *up_map, int i, unsigned int v)

static int map_get(u64 up_map, int i)
{
return (up_map & (1 << i)) >> i;
return (up_map & (1ULL << i)) >> i;
}

static struct tipc_peer *peer_prev(struct tipc_peer *peer)
Expand Down

0 comments on commit 63e19e5

Please sign in to comment.