Skip to content

Commit

Permalink
arm64: dts: imx8mp-evk: Fix hdmi@3d node
Browse files Browse the repository at this point in the history
[ Upstream commit 0ff08803eca417dfa9372194bebf3d1b1f501f98 ]

The hdmi@3d node's compatible string is "adi,adv7535" instead of
"adi,adv7533" or "adi,adv751*".

Fix the hdmi@3d node by means of:
* Use default register addresses for "cec", "edid" and "packet", because
  there is no need to use a non-default address map.
* Add missing interrupt related properties.
* Drop "adi,input-*" properties which are only valid for adv751*.
* Add VEXT_3V3 fixed regulator.
* Add "*-supply" properties, since most are required.
* Fix label names - s/adv7533/adv7535/.

Fixes: 65344b9 ("arm64: dts: imx8mp-evk: Add HDMI support")
Signed-off-by: Liu Ying <victor.liu@nxp.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Liu Ying authored and Sasha Levin committed Mar 26, 2024
1 parent 1d77f1f commit 656311b
Showing 1 changed file with 21 additions and 12 deletions.
33 changes: 21 additions & 12 deletions arch/arm64/boot/dts/freescale/imx8mp-evk.dts
Expand Up @@ -23,7 +23,7 @@

port {
hdmi_connector_in: endpoint {
remote-endpoint = <&adv7533_out>;
remote-endpoint = <&adv7535_out>;
};
};
};
Expand Down Expand Up @@ -107,6 +107,13 @@
enable-active-high;
};

reg_vext_3v3: regulator-vext-3v3 {
compatible = "regulator-fixed";
regulator-name = "VEXT_3V3";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
};

sound {
compatible = "simple-audio-card";
simple-audio-card,name = "wm8960-audio";
Expand Down Expand Up @@ -342,7 +349,7 @@
regulator-always-on;
};

BUCK5 {
reg_buck5: BUCK5 {
regulator-name = "BUCK5";
regulator-min-microvolt = <1650000>;
regulator-max-microvolt = <1950000>;
Expand Down Expand Up @@ -393,14 +400,16 @@

hdmi@3d {
compatible = "adi,adv7535";
reg = <0x3d>, <0x3c>, <0x3e>, <0x3f>;
reg-names = "main", "cec", "edid", "packet";
reg = <0x3d>;
interrupt-parent = <&gpio1>;
interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
adi,dsi-lanes = <4>;
adi,input-depth = <8>;
adi,input-colorspace = "rgb";
adi,input-clock = "1x";
adi,input-style = <1>;
adi,input-justification = "evenly";
avdd-supply = <&reg_buck5>;
dvdd-supply = <&reg_buck5>;
pvdd-supply = <&reg_buck5>;
a2vdd-supply = <&reg_buck5>;
v3p3-supply = <&reg_vext_3v3>;
v1p2-supply = <&reg_buck5>;

ports {
#address-cells = <1>;
Expand All @@ -409,15 +418,15 @@
port@0 {
reg = <0>;

adv7533_in: endpoint {
adv7535_in: endpoint {
remote-endpoint = <&dsi_out>;
};
};

port@1 {
reg = <1>;

adv7533_out: endpoint {
adv7535_out: endpoint {
remote-endpoint = <&hdmi_connector_in>;
};
};
Expand Down Expand Up @@ -502,7 +511,7 @@
reg = <1>;

dsi_out: endpoint {
remote-endpoint = <&adv7533_in>;
remote-endpoint = <&adv7535_in>;
data-lanes = <1 2 3 4>;
};
};
Expand Down

0 comments on commit 656311b

Please sign in to comment.