Skip to content

Commit

Permalink
arm64: dts: rockchip: Switch RK3399-Gru DP to SPDIF output
Browse files Browse the repository at this point in the history
commit b5fbaf7 upstream.

Commit b18c6c3 ("ASoC: rockchip: cdn-dp sound output use spdif")
switched the platform to SPDIF, but we didn't fix up the device tree.

Drop the pinctrl settings, because the 'spdif_bus' pins are either:
 * unused (on kevin, bob), so the settings is ~harmless
 * used by a different function (on scarlet), which causes probe
   failures (!!)

Fixes: b18c6c3 ("ASoC: rockchip: cdn-dp sound output use spdif")
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
Link: https://lore.kernel.org/r/20220114150129.v2.1.I46f64b00508d9dff34abe1c3e8d2defdab4ea1e5@changeid
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
computersforpeace authored and gregkh committed Mar 8, 2022
1 parent daea238 commit 6609f82
Showing 1 changed file with 12 additions and 5 deletions.
17 changes: 12 additions & 5 deletions arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
Expand Up @@ -286,7 +286,7 @@

sound: sound {
compatible = "rockchip,rk3399-gru-sound";
rockchip,cpu = <&i2s0 &i2s2>;
rockchip,cpu = <&i2s0 &spdif>;
};
};

Expand Down Expand Up @@ -437,10 +437,6 @@ ap_i2c_audio: &i2c8 {
status = "okay";
};

&i2s2 {
status = "okay";
};

&io_domains {
status = "okay";

Expand Down Expand Up @@ -537,6 +533,17 @@ ap_i2c_audio: &i2c8 {
vqmmc-supply = <&ppvar_sd_card_io>;
};

&spdif {
status = "okay";

/*
* SPDIF is routed internally to DP; we either don't use these pins, or
* mux them to something else.
*/
/delete-property/ pinctrl-0;
/delete-property/ pinctrl-names;
};

&spi1 {
status = "okay";

Expand Down

0 comments on commit 6609f82

Please sign in to comment.