Skip to content

Commit

Permalink
soc/tegra: Fix an error handling path in tegra_powergate_power_up()
Browse files Browse the repository at this point in the history
[ Upstream commit 986b509 ]

If an error occurs after a successful tegra_powergate_enable_clocks()
call, it must be undone by a tegra_powergate_disable_clocks() call, as
already done in the below and above error handling paths of this function.

Update the 'goto' to branch at the correct place of the error handling
path.

Fixes: a380451 ("soc/tegra: pmc: Add generic PM domain support")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
tititiou36 authored and gregkh committed Nov 17, 2021
1 parent 3a39364 commit 677ee2d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/soc/tegra/pmc.c
Expand Up @@ -782,7 +782,7 @@ static int tegra_powergate_power_up(struct tegra_powergate *pg,

err = reset_control_deassert(pg->reset);
if (err)
goto powergate_off;
goto disable_clks;

usleep_range(10, 20);

Expand Down

0 comments on commit 677ee2d

Please sign in to comment.