Skip to content

Commit

Permalink
ASoC: cs35l56: fix reversed if statement in cs35l56_dspwait_asp1tx_put()
Browse files Browse the repository at this point in the history
commit 4703b01 upstream.

It looks like the "!" character was added accidentally.  The
regmap_update_bits_check() function is normally going to succeed.  This
means the rest of the function is unreachable and we don't handle the
situation where "changed" is true correctly.

Fixes: 07f7d6e ("ASoC: cs35l56: Fix for initializing ASP1 mixer registers")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://lore.kernel.org/r/0c254c07-d1c0-4a5c-a22b-7e135cab032c@moroto.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Dan Carpenter authored and gregkh committed Mar 6, 2024
1 parent 43ba9e3 commit 67c8cf1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sound/soc/codecs/cs35l56.c
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ static int cs35l56_dspwait_asp1tx_put(struct snd_kcontrol *kcontrol,

ret = regmap_update_bits_check(cs35l56->base.regmap, addr,
CS35L56_ASP_TXn_SRC_MASK, val, &changed);
if (!ret)
if (ret)
return ret;

if (changed)
Expand Down

0 comments on commit 67c8cf1

Please sign in to comment.