Skip to content

Commit

Permalink
wifi: rtw89: debug: Fix error handling in rtw89_debug_priv_btc_manual…
Browse files Browse the repository at this point in the history
…_set()

[ Upstream commit 59b4cc4 ]

If there is a failure during kstrtobool_from_user()
rtw89_debug_priv_btc_manual_set should return a negative error code
instead of returning the count directly.

Fix this bug by returning an error code instead of a count after
a failed call of the function "kstrtobool_from_user". Moreover
I omitted the label "out" with this source code correction.

Fixes: e3ec701 ("rtw89: add Realtek 802.11ax driver")
Signed-off-by: Zhang Shurong <zhang_shurong@foxmail.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/tencent_1C09B99BD7DA9CAD18B00C8F0F050F540607@qq.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
ZhangShurong authored and gregkh committed Sep 13, 2023
1 parent 39a6b4b commit 6bf4cca
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions drivers/net/wireless/realtek/rtw89/debug.c
Expand Up @@ -2302,12 +2302,14 @@ static ssize_t rtw89_debug_priv_btc_manual_set(struct file *filp,
struct rtw89_dev *rtwdev = debugfs_priv->rtwdev;
struct rtw89_btc *btc = &rtwdev->btc;
bool btc_manual;
int ret;

if (kstrtobool_from_user(user_buf, count, &btc_manual))
goto out;
ret = kstrtobool_from_user(user_buf, count, &btc_manual);
if (ret)
return ret;

btc->ctrl.manual = btc_manual;
out:

return count;
}

Expand Down

0 comments on commit 6bf4cca

Please sign in to comment.