Skip to content

Commit

Permalink
ASoC: wm8958: Fix change notifications for DSP controls
Browse files Browse the repository at this point in the history
commit b4f5c6b upstream.

The WM8958 DSP controls all return 0 on successful write, not a boolean
value indicating if the write changed the value of the control. Fix this
by returning 1 after a change, there is already a check at the start of
each put() that skips the function in the case that there is no change.

Signed-off-by: Mark Brown <broonie@kernel.org>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20220416125408.197440-1-broonie@kernel.org
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
broonie authored and gregkh committed May 12, 2022
1 parent 99fa696 commit 6d58a6c
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions sound/soc/codecs/wm8958-dsp2.c
Expand Up @@ -530,7 +530,7 @@ static int wm8958_mbc_put(struct snd_kcontrol *kcontrol,

wm8958_dsp_apply(component, mbc, wm8994->mbc_ena[mbc]);

return 0;
return 1;
}

#define WM8958_MBC_SWITCH(xname, xval) {\
Expand Down Expand Up @@ -656,7 +656,7 @@ static int wm8958_vss_put(struct snd_kcontrol *kcontrol,

wm8958_dsp_apply(component, vss, wm8994->vss_ena[vss]);

return 0;
return 1;
}


Expand Down Expand Up @@ -730,7 +730,7 @@ static int wm8958_hpf_put(struct snd_kcontrol *kcontrol,

wm8958_dsp_apply(component, hpf % 3, ucontrol->value.integer.value[0]);

return 0;
return 1;
}

#define WM8958_HPF_SWITCH(xname, xval) {\
Expand Down Expand Up @@ -824,7 +824,7 @@ static int wm8958_enh_eq_put(struct snd_kcontrol *kcontrol,

wm8958_dsp_apply(component, eq, ucontrol->value.integer.value[0]);

return 0;
return 1;
}

#define WM8958_ENH_EQ_SWITCH(xname, xval) {\
Expand Down

0 comments on commit 6d58a6c

Please sign in to comment.