Skip to content

Commit

Permalink
spi: mxs: fix reference leak in mxs_spi_probe
Browse files Browse the repository at this point in the history
[ Upstream commit 03fc41a ]

pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to pm_runtime_put_noidle will result in
reference leak in mxs_spi_probe, so we should fix it.

Fixes: b7969ca ("spi: mxs: implement runtime pm")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20201106012421.95420-1-zhangqilong3@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Zhang Qilong authored and gregkh committed Dec 30, 2020
1 parent 5df0455 commit 6f8c6e7
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/spi/spi-mxs.c
Expand Up @@ -608,6 +608,7 @@ static int mxs_spi_probe(struct platform_device *pdev)

ret = pm_runtime_get_sync(ssp->dev);
if (ret < 0) {
pm_runtime_put_noidle(ssp->dev);
dev_err(ssp->dev, "runtime_get_sync failed\n");
goto out_pm_runtime_disable;
}
Expand Down

0 comments on commit 6f8c6e7

Please sign in to comment.