Skip to content

Commit

Permalink
slimbus: qcom-ngd-ctrl: disable ngd in qmi server down callback
Browse files Browse the repository at this point in the history
In QMI new server notification we enable the NGD however during
delete server notification we do not disable the NGD.

This can lead to multiple instances of NGD being enabled, so make
sure that we disable NGD in delete server callback to fix this issue!

Fixes: 917809e ("slimbus: ngd: Add qcom SLIMBus NGD driver")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20200925095520.27316-4-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Srinivas-Kandagatla authored and gregkh committed Sep 25, 2020
1 parent df2c471 commit 709ec3f
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/slimbus/qcom-ngd-ctrl.c
Original file line number Diff line number Diff line change
Expand Up @@ -1277,9 +1277,13 @@ static void qcom_slim_ngd_qmi_del_server(struct qmi_handle *hdl,
{
struct qcom_slim_ngd_qmi *qmi =
container_of(hdl, struct qcom_slim_ngd_qmi, svc_event_hdl);
struct qcom_slim_ngd_ctrl *ctrl =
container_of(qmi, struct qcom_slim_ngd_ctrl, qmi);

qmi->svc_info.sq_node = 0;
qmi->svc_info.sq_port = 0;

qcom_slim_ngd_enable(ctrl, false);
}

static struct qmi_ops qcom_slim_ngd_qmi_svc_event_ops = {
Expand Down

0 comments on commit 709ec3f

Please sign in to comment.