Skip to content

Commit

Permalink
scmi-cpufreq: Remove deferred probe
Browse files Browse the repository at this point in the history
The current implementation of the scmi_cpufreq_init() function returns
-EPROBE_DEFER when the OPP table is not populated. In practice the
cpufreq core cannot handle this error code.
Therefore, fix the return value and clarify the error message.

Link: https://lore.kernel.org/r/20210218222326.15788-2-nicola.mazzucato@arm.com
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Nicola Mazzucato <nicola.mazzucato@arm.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
  • Loading branch information
nicola-mazzucato-arm authored and sudeep-holla committed Mar 15, 2021
1 parent a38fd87 commit 71a37cd
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions drivers/cpufreq/scmi-cpufreq.c
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,10 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy)

nr_opp = dev_pm_opp_get_opp_count(cpu_dev);
if (nr_opp <= 0) {
dev_dbg(cpu_dev, "OPP table is not ready, deferring probe\n");
ret = -EPROBE_DEFER;
dev_err(cpu_dev, "%s: No OPPs for this device: %d\n",
__func__, ret);

ret = -ENODEV;
goto out_free_opp;
}

Expand Down

0 comments on commit 71a37cd

Please sign in to comment.