Skip to content

Commit

Permalink
scsi: iscsi: Do not put host in iscsi_set_flashnode_param()
Browse files Browse the repository at this point in the history
[ Upstream commit 68e12e5 ]

If scsi_host_lookup() fails we will jump to put_host which may cause a
panic. Jump to exit_set_fnode instead.

Link: https://lore.kernel.org/r/20200615081226.183068-1-jingxiangfeng@huawei.com
Reviewed-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
hiss2018 authored and gregkh committed Sep 3, 2020
1 parent b83f035 commit 71e8627
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/scsi/scsi_transport_iscsi.c
Expand Up @@ -3291,7 +3291,7 @@ static int iscsi_set_flashnode_param(struct iscsi_transport *transport,
pr_err("%s could not find host no %u\n",
__func__, ev->u.set_flashnode.host_no);
err = -ENODEV;
goto put_host;
goto exit_set_fnode;
}

idx = ev->u.set_flashnode.flashnode_idx;
Expand Down

0 comments on commit 71e8627

Please sign in to comment.