Skip to content

Commit

Permalink
rds: memory leak in __rds_conn_create()
Browse files Browse the repository at this point in the history
[ Upstream commit 5f9562e ]

__rds_conn_create() did not release conn->c_path when loop_trans != 0 and
trans->t_prefer_loopback != 0 and is_outgoing == 0.

Fixes: aced3ce ("RDS tcp loopback connection can hang")
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Reviewed-by: Sharath Srinivasan <sharath.srinivasan@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
HBh25Y authored and gregkh committed Dec 22, 2021
1 parent 67f4362 commit 74dc97d
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions net/rds/connection.c
Expand Up @@ -253,6 +253,7 @@ static struct rds_connection *__rds_conn_create(struct net *net,
* should end up here, but if it
* does, reset/destroy the connection.
*/
kfree(conn->c_path);
kmem_cache_free(rds_conn_slab, conn);
conn = ERR_PTR(-EOPNOTSUPP);
goto out;
Expand Down

0 comments on commit 74dc97d

Please sign in to comment.