Skip to content

Commit

Permalink
ASoC: Intel: Skylake: Fix driver hang during shutdown
Browse files Browse the repository at this point in the history
[ Upstream commit 1711072 ]

AudioDSP cores and HDAudio links need to be turned off on shutdown to
ensure no communication or data transfer occurs during the procedure.

Fixes: c5a76a2 ("ASoC: Intel: Skylake: Add shutdown callback")
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Tested-by: Lukasz Majczak <lma@semihlaf.com>
Link: https://lore.kernel.org/r/20221205085330.857665-6-cezary.rojewski@intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
crojewsk-intel authored and gregkh committed Dec 31, 2022
1 parent 33ff0f9 commit 7643909
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion sound/soc/intel/skylake/skl.c
Expand Up @@ -1096,7 +1096,10 @@ static void skl_shutdown(struct pci_dev *pci)
if (!skl->init_done)
return;

snd_hdac_stop_streams_and_chip(bus);
snd_hdac_stop_streams(bus);
snd_hdac_ext_bus_link_power_down_all(bus);
skl_dsp_sleep(skl->dsp);

list_for_each_entry(s, &bus->stream_list, list) {
stream = stream_to_hdac_ext_stream(s);
snd_hdac_ext_stream_decouple(bus, stream, false);
Expand Down

0 comments on commit 7643909

Please sign in to comment.