Skip to content

Commit

Permalink
mac80211: validate extended element ID is present
Browse files Browse the repository at this point in the history
Before attempting to parse an extended element, verify that
the extended element ID is present.

Fixes: 41cbb0f ("mac80211: add support for HE")
Reported-by: syzbot+59bdff68edce82e393b6@syzkaller.appspotmail.com
Link: https://lore.kernel.org/r/20211211201023.f30a1b128c07.I5cacc176da94ba316877c6e10fe3ceec8b4dbd7d@changeid
Cc: stable@vger.kernel.org
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
  • Loading branch information
jmberg-intel committed Dec 14, 2021
1 parent e08ebd6 commit 768c0b1
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion net/mac80211/util.c
Original file line number Diff line number Diff line change
Expand Up @@ -943,7 +943,12 @@ static void ieee80211_parse_extension_element(u32 *crc,
struct ieee802_11_elems *elems)
{
const void *data = elem->data + 1;
u8 len = elem->datalen - 1;
u8 len;

if (!elem->datalen)
return;

len = elem->datalen - 1;

switch (elem->data[0]) {
case WLAN_EID_EXT_HE_MU_EDCA:
Expand Down

0 comments on commit 768c0b1

Please sign in to comment.