Skip to content

Commit

Permalink
leds: disallow /sys/class/leds/*:multi:* for now
Browse files Browse the repository at this point in the history
All the LEDs in the queue are RGB, so they should not use multi for
their color.

Make sure we don't add such LED by mistake (and make it part of ABI).

Signed-off-by: Pavel Machek <pavel@ucw.cz>
  • Loading branch information
pavelmachek committed Aug 3, 2020
1 parent 54212f5 commit 77dce3a
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/leds/led-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,10 @@ int led_compose_name(struct device *dev, struct led_init_data *init_data,
struct fwnode_handle *fwnode = init_data->fwnode;
const char *devicename = init_data->devicename;

/* We want to label LEDs that can produce full range of colors
* as RGB, not multicolor */
BUG_ON(props.color == LED_COLOR_ID_MULTI);

if (!led_classdev_name)
return -EINVAL;

Expand Down

0 comments on commit 77dce3a

Please sign in to comment.