Skip to content

Commit

Permalink
workqueue: Move the position of debug_work_activate() in __queue_work()
Browse files Browse the repository at this point in the history
[ Upstream commit 0687c66 ]

The debug_work_activate() is called on the premise that
the work can be inserted, because if wq be in WQ_DRAINING
status, insert work may be failed.

Fixes: e41e704 ("workqueue: improve destroy_workqueue() debuggability")
Signed-off-by: Zqiang <qiang.zhang@windriver.com>
Reviewed-by: Lai Jiangshan <jiangshanlai@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Zqiang1211 authored and gregkh committed Apr 14, 2021
1 parent b3f29ed commit 7943f74
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion kernel/workqueue.c
Original file line number Diff line number Diff line change
Expand Up @@ -1409,7 +1409,6 @@ static void __queue_work(int cpu, struct workqueue_struct *wq,
*/
lockdep_assert_irqs_disabled();

debug_work_activate(work);

/* if draining, only works from the same workqueue are allowed */
if (unlikely(wq->flags & __WQ_DRAINING) &&
Expand Down Expand Up @@ -1491,6 +1490,7 @@ static void __queue_work(int cpu, struct workqueue_struct *wq,
worklist = &pwq->delayed_works;
}

debug_work_activate(work);
insert_work(pwq, work, worklist, work_flags);

out:
Expand Down

0 comments on commit 7943f74

Please sign in to comment.