Skip to content

Commit

Permalink
tty: serial: 8250: serial_cs: Fix a memory leak in error handling path
Browse files Browse the repository at this point in the history
[ Upstream commit fad92b1 ]

In the probe function, if the final 'serial_config()' fails, 'info' is
leaking.

Add a resource handling path to free this memory.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/dc25f96b7faebf42e60fe8d02963c941cf4d8124.1621971720.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
tititiou36 authored and gregkh committed Jul 20, 2021
1 parent 75452cc commit 7a80f71
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion drivers/tty/serial/8250/serial_cs.c
Expand Up @@ -306,6 +306,7 @@ static int serial_resume(struct pcmcia_device *link)
static int serial_probe(struct pcmcia_device *link)
{
struct serial_info *info;
int ret;

dev_dbg(&link->dev, "serial_attach()\n");

Expand All @@ -320,7 +321,15 @@ static int serial_probe(struct pcmcia_device *link)
if (do_sound)
link->config_flags |= CONF_ENABLE_SPKR;

return serial_config(link);
ret = serial_config(link);
if (ret)
goto free_info;

return 0;

free_info:
kfree(info);
return ret;
}

static void serial_detach(struct pcmcia_device *link)
Expand Down

0 comments on commit 7a80f71

Please sign in to comment.