Skip to content

Commit

Permalink
cifs: return errors during session setup during reconnects
Browse files Browse the repository at this point in the history
commit 8ea2182 upstream.

During reconnects, we check the return value from
cifs_negotiate_protocol, and have handlers for both success
and failures. But if that passes, and cifs_setup_session
returns any errors other than -EACCES, we do not handle
that. This fix adds a handler for that, so that we don't
go ahead and try a tree_connect on a failed session.

Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>
Reviewed-by: Enzo Matsumiya <ematsumiya@suse.de>
Cc: stable@vger.kernel.org
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
sprasad-microsoft authored and gregkh committed Jun 14, 2022
1 parent 7004840 commit 7aa4b31
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions fs/cifs/smb2pdu.c
Expand Up @@ -268,6 +268,9 @@ smb2_reconnect(__le16 smb2_command, struct cifs_tcon *tcon,
ses->binding_chan = NULL;
mutex_unlock(&tcon->ses->session_mutex);
goto failed;
} else if (rc) {
mutex_unlock(&ses->session_mutex);
goto out;
}
}
/*
Expand Down

0 comments on commit 7aa4b31

Please sign in to comment.