Skip to content

Commit

Permalink
i2c: mt65xx: fix IRQ check
Browse files Browse the repository at this point in the history
[ Upstream commit 58fb7c6 ]

Iff platform_get_irq() returns 0, the driver's probe() method will return 0
early (as if the method's call was successful).  Let's consider IRQ0 valid
for simplicity -- devm_request_irq() can always override that decision...

Fixes: ce38815 ("I2C: mediatek: Add driver for MediaTek I2C controller")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
Reviewed-by: Qii Wang <qii.wang@mediatek.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Sergey Shtylyov authored and gregkh committed Sep 15, 2021
1 parent 6c48572 commit 7ac3090
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/i2c/busses/i2c-mt65xx.c
Expand Up @@ -1207,7 +1207,7 @@ static int mtk_i2c_probe(struct platform_device *pdev)
return PTR_ERR(i2c->pdmabase);

irq = platform_get_irq(pdev, 0);
if (irq <= 0)
if (irq < 0)
return irq;

init_completion(&i2c->msg_complete);
Expand Down

0 comments on commit 7ac3090

Please sign in to comment.