Skip to content

Commit

Permalink
drm/amd/display: Do not clear GPINT register when releasing DMUB from…
Browse files Browse the repository at this point in the history
… reset

[ Upstream commit 99d92ea ]

[Why & How]
There's no need to clear GPINT register for DMUB
when releasing it from reset. Fix that.

Fixes: ac2e555 ("drm/amd/display: Add DMCUB source files and changes for DCN32/321")
Reviewed-by: Leo Li <sunpeng.li@amd.com>
Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Aurabindo Pillai authored and gregkh committed May 17, 2023
1 parent ccb0ad9 commit 7bba2e5
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/gpu/drm/amd/display/dmub/src/dmub_dcn32.c
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ void dmub_dcn32_reset(struct dmub_srv *dmub)

void dmub_dcn32_reset_release(struct dmub_srv *dmub)
{
REG_WRITE(DMCUB_GPINT_DATAIN1, 0);
REG_UPDATE(MMHUBBUB_SOFT_RESET, DMUIF_SOFT_RESET, 0);
REG_WRITE(DMCUB_SCRATCH15, dmub->psp_version & 0x001100FF);
REG_UPDATE_2(DMCUB_CNTL, DMCUB_ENABLE, 1, DMCUB_TRACEPORT_EN, 1);
Expand Down

0 comments on commit 7bba2e5

Please sign in to comment.