Skip to content

Commit

Permalink
ASoC: imx-hdmi: Fix refcount leak in imx_hdmi_probe
Browse files Browse the repository at this point in the history
[ Upstream commit ed46731 ]

of_find_device_by_node() takes reference, we should use put_device()
to release it. when devm_kzalloc() fails, it doesn't have a
put_device(), it will cause refcount leak.
Add missing put_device() to fix this.

Fixes: 6a5f850 ("ASoC: fsl: Add imx-hdmi machine driver")
Fixes: f670b27 ("ASoC: imx-hdmi: add put_device() after of_find_device_by_node()")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220511052740.46903-1-linmq006@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Yuuoniy authored and gregkh committed Jun 9, 2022
1 parent 4bfbbfd commit 8205a01
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions sound/soc/fsl/imx-hdmi.c
Expand Up @@ -126,6 +126,7 @@ static int imx_hdmi_probe(struct platform_device *pdev)
data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
if (!data) {
ret = -ENOMEM;
put_device(&cpu_pdev->dev);
goto fail;
}

Expand Down

0 comments on commit 8205a01

Please sign in to comment.