Skip to content

Commit

Permalink
ASoC: mediatek: mt8186: Correct I2S shared clocks
Browse files Browse the repository at this point in the history
[ Upstream commit 248579f ]

In mt8186 platform, I2S2 should be the main I2S port that provide
the clock, on the contrary I2S3 should be the second I2S port that
use this clock.

Fixes: 9986bda ("ASoC: mediatek: mt8186: Configure shared clocks")
Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20221124023050.4470-1-jiaxin.yu@mediatek.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
yujiaxinff authored and gregkh committed Dec 31, 2022
1 parent 5827a56 commit 841315c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ static int mt8186_mt6366_da7219_max98357_hdmi_init(struct snd_soc_pcm_runtime *r
struct mt8186_mt6366_da7219_max98357_priv *priv = soc_card_data->mach_priv;
int ret;

ret = mt8186_dai_i2s_set_share(afe, "I2S3", "I2S2");
ret = mt8186_dai_i2s_set_share(afe, "I2S2", "I2S3");
if (ret) {
dev_err(rtd->dev, "Failed to set up shared clocks\n");
return ret;
Expand Down
2 changes: 1 addition & 1 deletion sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ static int mt8186_mt6366_rt1019_rt5682s_hdmi_init(struct snd_soc_pcm_runtime *rt
struct mt8186_mt6366_rt1019_rt5682s_priv *priv = soc_card_data->mach_priv;
int ret;

ret = mt8186_dai_i2s_set_share(afe, "I2S3", "I2S2");
ret = mt8186_dai_i2s_set_share(afe, "I2S2", "I2S3");
if (ret) {
dev_err(rtd->dev, "Failed to set up shared clocks\n");
return ret;
Expand Down

0 comments on commit 841315c

Please sign in to comment.