Skip to content

Commit

Permalink
netrom: Fix a data-race around sysctl_netrom_routing_control
Browse files Browse the repository at this point in the history
[ Upstream commit b5dffcb ]

We need to protect the reader reading the sysctl value because the
value can be changed concurrently.

Fixes: 1da177e ("Linux-2.6.12-rc2")
Signed-off-by: Jason Xing <kernelxing@tencent.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
JasonXing authored and Sasha Levin committed Mar 15, 2024
1 parent 6f254ab commit 859175d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/netrom/nr_route.c
Original file line number Diff line number Diff line change
Expand Up @@ -780,7 +780,7 @@ int nr_route_frame(struct sk_buff *skb, ax25_cb *ax25)
return ret;
}

if (!sysctl_netrom_routing_control && ax25 != NULL)
if (!READ_ONCE(sysctl_netrom_routing_control) && ax25 != NULL)
return 0;

/* Its Time-To-Live has expired */
Expand Down

0 comments on commit 859175d

Please sign in to comment.