Skip to content

Commit

Permalink
soc: qcom: aoss: Fix missing put_device call in qmp_get
Browse files Browse the repository at this point in the history
[ Upstream commit 4b41a9d ]

The reference taken by 'of_find_device_by_node()' must be released when
not needed anymore.
Add the corresponding 'put_device()' in the error handling paths.

Fixes: 8c75d58 ("soc: qcom: aoss: Expose send for generic usecase")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20220108095931.21527-1-linmq006@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Yuuoniy authored and gregkh committed Apr 8, 2022
1 parent f3106d4 commit 863bf0d
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion drivers/soc/qcom/qcom_aoss.c
Expand Up @@ -451,7 +451,11 @@ struct qmp *qmp_get(struct device *dev)

qmp = platform_get_drvdata(pdev);

return qmp ? qmp : ERR_PTR(-EPROBE_DEFER);
if (!qmp) {
put_device(&pdev->dev);
return ERR_PTR(-EPROBE_DEFER);
}
return qmp;
}
EXPORT_SYMBOL(qmp_get);

Expand Down

0 comments on commit 863bf0d

Please sign in to comment.