Skip to content

Commit

Permalink
pwm: tegra: Don't modify HW state in .remove callback
Browse files Browse the repository at this point in the history
A consumer is expected to disable a PWM before calling pwm_put(). And if
they didn't there is hopefully a good reason (or the consumer needs
fixing). Also if disabling an enabled PWM was the right thing to do,
this should better be done in the framework instead of in each low level
driver.

So drop the hardware modification from the .remove() callback.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
  • Loading branch information
Uwe Kleine-König authored and thierryreding committed Jun 30, 2021
1 parent c1b8ac9 commit 86f7fa7
Showing 1 changed file with 0 additions and 13 deletions.
13 changes: 0 additions & 13 deletions drivers/pwm/pwm-tegra.c
Original file line number Diff line number Diff line change
Expand Up @@ -300,25 +300,12 @@ static int tegra_pwm_probe(struct platform_device *pdev)
static int tegra_pwm_remove(struct platform_device *pdev)
{
struct tegra_pwm_chip *pc = platform_get_drvdata(pdev);
unsigned int i;
int err;

err = clk_prepare_enable(pc->clk);
if (err < 0)
return err;

for (i = 0; i < pc->chip.npwm; i++) {
struct pwm_device *pwm = &pc->chip.pwms[i];

if (!pwm_is_enabled(pwm))
if (clk_prepare_enable(pc->clk) < 0)
continue;

pwm_writel(pc, i, 0);

clk_disable_unprepare(pc->clk);
}

reset_control_assert(pc->rst);
clk_disable_unprepare(pc->clk);

Expand Down

0 comments on commit 86f7fa7

Please sign in to comment.