Skip to content

Commit

Permalink
locking/rtmutex: Set proper wait context for lockdep
Browse files Browse the repository at this point in the history
[ Upstream commit b41cda0 ]

RT mutexes belong to the LD_WAIT_SLEEP class. Make them so.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20210815211302.031014562@linutronix.de
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Thomas Gleixner authored and gregkh committed Sep 18, 2021
1 parent 32bc092 commit 874c5ff
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 8 deletions.
19 changes: 12 additions & 7 deletions include/linux/rtmutex.h
Expand Up @@ -52,17 +52,22 @@ do { \
} while (0)

#ifdef CONFIG_DEBUG_LOCK_ALLOC
#define __DEP_MAP_RT_MUTEX_INITIALIZER(mutexname) \
, .dep_map = { .name = #mutexname }
#define __DEP_MAP_RT_MUTEX_INITIALIZER(mutexname) \
.dep_map = { \
.name = #mutexname, \
.wait_type_inner = LD_WAIT_SLEEP, \
}
#else
#define __DEP_MAP_RT_MUTEX_INITIALIZER(mutexname)
#endif

#define __RT_MUTEX_INITIALIZER(mutexname) \
{ .wait_lock = __RAW_SPIN_LOCK_UNLOCKED(mutexname.wait_lock) \
, .waiters = RB_ROOT_CACHED \
, .owner = NULL \
__DEP_MAP_RT_MUTEX_INITIALIZER(mutexname)}
#define __RT_MUTEX_INITIALIZER(mutexname) \
{ \
.wait_lock = __RAW_SPIN_LOCK_UNLOCKED(mutexname.wait_lock), \
.waiters = RB_ROOT_CACHED, \
.owner = NULL, \
__DEP_MAP_RT_MUTEX_INITIALIZER(mutexname) \
}

#define DEFINE_RT_MUTEX(mutexname) \
struct rt_mutex mutexname = __RT_MUTEX_INITIALIZER(mutexname)
Expand Down
2 changes: 1 addition & 1 deletion kernel/locking/rtmutex.c
Expand Up @@ -1556,7 +1556,7 @@ void __sched __rt_mutex_init(struct rt_mutex *lock, const char *name,
struct lock_class_key *key)
{
debug_check_no_locks_freed((void *)lock, sizeof(*lock));
lockdep_init_map(&lock->dep_map, name, key, 0);
lockdep_init_map_wait(&lock->dep_map, name, key, 0, LD_WAIT_SLEEP);

__rt_mutex_basic_init(lock);
}
Expand Down

0 comments on commit 874c5ff

Please sign in to comment.