Skip to content

Commit

Permalink
reset: bail if try_module_get() fails
Browse files Browse the repository at this point in the history
[ Upstream commit 4fb26fb ]

Abort instead of returning a new reset control for a reset controller
device that is going to have its module unloaded.

Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fixes: 61fc413 ("reset: Add reset controller API")
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20210607082615.15160-1-p.zabel@pengutronix.de
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
pH5 authored and gregkh committed Jul 20, 2021
1 parent 8c07e1a commit 884d09d
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion drivers/reset/core.c
Expand Up @@ -567,7 +567,10 @@ static struct reset_control *__reset_control_get_internal(
if (!rstc)
return ERR_PTR(-ENOMEM);

try_module_get(rcdev->owner);
if (!try_module_get(rcdev->owner)) {
kfree(rstc);
return ERR_PTR(-ENODEV);
}

rstc->rcdev = rcdev;
list_add(&rstc->list, &rcdev->reset_control_head);
Expand Down

0 comments on commit 884d09d

Please sign in to comment.