Skip to content

Commit

Permalink
clk: qcom: gcc-ipq5018: fix terminating of frequency table arrays
Browse files Browse the repository at this point in the history
The frequency table arrays are supposed to be terminated with an
empty element. Add such entry to the end of the arrays where it
is missing in order to avoid possible out-of-bound access when
the table is traversed by functions like qcom_find_freq() or
qcom_find_freq_floor().

Fixes: e3fdbef ("clk: qcom: Add Global Clock controller (GCC) driver for IPQ5018")
Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20240229-freq-table-terminator-v1-1-074334f0905c@gmail.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
  • Loading branch information
juhosg authored and andersson committed Mar 2, 2024
1 parent 117e7dc commit 90ad946
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/clk/qcom/gcc-ipq5018.c
Original file line number Diff line number Diff line change
Expand Up @@ -857,6 +857,7 @@ static struct clk_rcg2 lpass_sway_clk_src = {

static const struct freq_tbl ftbl_pcie0_aux_clk_src[] = {
F(2000000, P_XO, 12, 0, 0),
{ }
};

static struct clk_rcg2 pcie0_aux_clk_src = {
Expand Down Expand Up @@ -1099,6 +1100,7 @@ static const struct freq_tbl ftbl_qpic_io_macro_clk_src[] = {
F(100000000, P_GPLL0, 8, 0, 0),
F(200000000, P_GPLL0, 4, 0, 0),
F(320000000, P_GPLL0, 2.5, 0, 0),
{ }
};

static struct clk_rcg2 qpic_io_macro_clk_src = {
Expand Down Expand Up @@ -1194,6 +1196,7 @@ static struct clk_rcg2 ubi0_axi_clk_src = {
static const struct freq_tbl ftbl_ubi0_core_clk_src[] = {
F(850000000, P_UBI32_PLL, 1, 0, 0),
F(1000000000, P_UBI32_PLL, 1, 0, 0),
{ }
};

static struct clk_rcg2 ubi0_core_clk_src = {
Expand Down

0 comments on commit 90ad946

Please sign in to comment.